Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
worst_ingredients
andbest_ingredients
methods in the User model with asorted_ingredients
method that takesflag
andcount
argumentsworst_ingredient_data
andbest_ingredient_data
methods with ato_data
class method in the Ingredient modelWhere should the reviewer start?
sorted_ingredients
method in the User modelto_data
method in the Ingredient modelThoughts/Refactors
sorted_ingredients
is never called without mapping the ingredients to a hash with theto_data
method, so just having one method that sorts the ingredients behind the scenes and returns the hash might be preferable